Skip to content

chore(test): Adds swabbie integration tests for docker builds#669

Open
jasonmcintosh wants to merge 9 commits into
spinnaker:masterfrom
armory-io:addIntegrationTests
Open

chore(test): Adds swabbie integration tests for docker builds#669
jasonmcintosh wants to merge 9 commits into
spinnaker:masterfrom
armory-io:addIntegrationTests

Conversation

@jasonmcintosh

Copy link
Copy Markdown
Member

Duplicates most of the other project integration tests with a FEW changes

  • Uses valkey for redis (license concern) and uses version 7.

@dbyron-sf

Copy link
Copy Markdown
Contributor

Doesn't this need a chance to some github actions to actually run the tests?

@jervi jervi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jasonmcintosh

Copy link
Copy Markdown
Member Author

Doesn't this need a chance to some github actions to actually run the tests?

Yeah :) I'd not gotten all the pieces configured. I should have probably put this as "draft" but hadn't worried too much. I THINK it's actually in a pretty good state now for merge.

"${{ env.CONTAINER_REGISTRY }}/${{ steps.build_variables.outputs.REPO }}:${{ github.ref_name }}-latest-java11-unvalidated-ubuntu"
"${{ env.CONTAINER_REGISTRY }}/${{ steps.build_variables.outputs.REPO }}:${{ steps.build_variables.outputs.VERSION }}-java11-unvalidated-ubuntu"

- name: Test local slim container image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr.yml also needs this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will add that :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And....it fails:

    APPLICATION FAILED TO START
    ***************************

    Description:

    Config data location '/home/spinnaker/.spinnaker/' does not exist

    Action:

    Check that the value '/home/spinnaker/.spinnaker/' is correct, or prefix it with 'optional:'

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah :) That's that kork config with the default locations if I recall right. Will dig & fix here later.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI fixed this with latest PR, but working through all the "clouddriver isn't available" as part of the integration tests. Got some more work to do on the downstream deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants